[Merged by Bors] - atx: cache poet proofs with lru #6336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshulyak
requested review from
fasmat,
poszu,
ivan4th and
acud
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6336 +/- ##
=========================================
- Coverage 81.8% 81.7% -0.1%
=========================================
Files 312 312
Lines 34606 34637 +31
=========================================
+ Hits 28314 28328 +14
- Misses 4461 4472 +11
- Partials 1831 1837 +6 ☔ View full report in Codecov by Sentry. |
poszu
reviewed
Sep 18, 2024
poszu
approved these changes
Sep 18, 2024
poszu
reviewed
Sep 18, 2024
|
@poszu updated with singleflight just in case, could you please check again? |
|
bors try |
tryBuild failed: |
poszu
approved these changes
Sep 19, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
followup for #6326 in current code poet proofs are fetched for every atx submitted to the node, they are relatively large (140KB) and account for sizeable chunk of all reads executed on the atx handler codepath (25%). they are also a perfect case for lru caching, they are mostly reused and replaced from epoch to epoch. basic stats in recent epochs. ``` select round_id, count(*), max(length(poet)) from poets group by round_id; 25|42|146200 26|45|145936 27|45|145738 28|45|145903 ```
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup for #6326
in current code poet proofs are fetched for every atx submitted to the node,
they are relatively large (140KB) and account for sizeable chunk of all reads executed on the atx handler codepath (25%).
they are also a perfect case for lru caching, they are mostly reused and replaced from epoch to epoch.
basic stats in recent epochs.